Re: [PATCH v2 4/7] rtw88: replace tx tasklet with tx work
flat view
From: Brian Norris <briannorris@chromium.org>
Date: 2021-01-13 19:05:54
On Wed, Jan 13, 2021 at 1:53 AM Ping-Ke Shih [off-list ref] wrote:
From: Po-Hao Huang <redacted> Move tx tasklet to thread, by this we can reduce time spent on waiting for schedule and have better efficiency. Signed-off-by: Po-Hao Huang <redacted> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
I'm curious, why a bare kthread and not just a (WQ_HIGHPRI?) workqueue? It seems like you're sort of reimplementing some of the workqueue semantics with your SCHEDULED and RUNNING flags, when queue_work() would do that for you. Brian