On 11/01/2021 11:28, Kalle Valo wrote:

Bryan O'Donoghue [off-list ref] writes:

quoted

Having enabled GTK rekey in suspend, we need to extract the replay counter
from the firmware on resume and perform a ieee80211_gtk_rekey_notify() so
that the STA remains verified from the perspective of the AP.

Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
---
  drivers/net/wireless/ath/wcn36xx/hal.h  |  4 +-
  drivers/net/wireless/ath/wcn36xx/main.c |  5 +-
  drivers/net/wireless/ath/wcn36xx/smd.c  | 72 +++++++++++++++++++++++++
  drivers/net/wireless/ath/wcn36xx/smd.h  |  3 ++
  4 files changed, 81 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/wcn36xx/hal.h b/drivers/net/wireless/ath/wcn36xx/hal.h
index 1f3c2e840232..455143c4164e 100644
--- a/drivers/net/wireless/ath/wcn36xx/hal.h
+++ b/drivers/net/wireless/ath/wcn36xx/hal.h

@@ -4919,7 +4919,7 @@ struct wcn36xx_hal_gtk_offload_rsp_msg {
  struct wcn36xx_hal_gtk_offload_get_info_req_msg {
  	struct wcn36xx_hal_msg_header header;
  	u8 bss_index;
-};
+} __packed;
  
  struct wcn36xx_hal_gtk_offload_get_info_rsp_msg {
  	struct wcn36xx_hal_msg_header header;

@@ -4943,7 +4943,7 @@ struct wcn36xx_hal_gtk_offload_get_info_rsp_msg {
  	u32 igtk_rekey_count;
  
  	u8 bss_index;
-};
+} __packed;

Why __packed? Commit log mentions nothing about that.

Because the __u8 at the end aligns to 4 bytes.

I'll add this to the log desc