Thread (7 messages) 7 messages, 7 authors, 2021-01-27

Re: [PATCH net] iwlwifi: provide gso_type to GSO packets

From: Eric Dumazet <edumazet@google.com>
Date: 2021-01-25 15:37:55
Also in: netdev

On Mon, Jan 25, 2021 at 4:15 PM Ben Greear [off-list ref] wrote:
On 1/25/21 7:09 AM, Eric Dumazet wrote:
quoted
From: Eric Dumazet <edumazet@google.com>

net/core/tso.c got recent support for USO, and this broke iwlfifi
because the driver implemented a limited form of GSO.

Providing ->gso_type allows for skb_is_gso_tcp() to provide
a correct result.

Fixes: 3d5b459ba0e3 ("net: tso: add UDP segmentation support")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Ben Greear <redacted>
Bisected-by: Ben Greear [off-list ref]
I appreciate the credit, but the bisect and some other initial bug hunting was
done by people on this thread:

https://bugzilla.kernel.org/show_bug.cgi?id=209913
Well, I do not think bugzilla can display full names/emails ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help