Re: net: tso: add UDP segmentation support: adds regression for ax200 upload
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2021-01-19 08:55:05
Also in:
netdev
Hi Eric, all, Sorry we've been so silent on this.
quoted hunk ↗ jump to hunk
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tx.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tx.c@@ -773,6 +773,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,unsigned int num_subframes, next = skb_gso_segment(skb, netdev_flags); skb_shinfo(skb)->gso_size = mss; + skb_shinfo(skb)->gso_type = ipv4 ? SKB_GSO_TCPV4 : SKB_GSO_TCPV6; if (WARN_ON_ONCE(IS_ERR(next))) return -EINVAL; else if (next)@@ -795,6 +796,7 @@ iwl_mvm_tx_tso_segment(struct sk_buff *skb,unsigned int num_subframes, if (tcp_payload_len > mss) { skb_shinfo(tmp)->gso_size = mss; + skb_shinfo(tmp)->gso_type = ipv4 ? SKB_GSO_TCPV4 : SKB_GSO_TCPV6; } else { if (qos) { u8 *qc;
This does fix the problems reported on iwlwifi, were you planning to submit it as a proper patch? Thanks, johannes