On Mon, Nov 2, 2020 at 7:01 PM Johannes Berg [off-list ref] wrote:

On Mon, 2020-11-02 at 18:26 +0200, Kalle Valo wrote:

quoted

Arnd Bergmann [off-list ref] writes:

quoted

From: Arnd Bergmann <arnd@arndb.de>

Isn't there a better way to handle this? I really would not want
checking for GCC versions become a common approach in drivers.

I even think that using memcpy() always is better than the ugly ifdef.

If you put memcpy() always somebody will surely go and clean it up to
use ether_addr_copy() soon ...

That said, if there's a gcc issue with ether_addr_copy() then how come
it's specific to this place?

I have not been able to figure this out, hopefully some gcc developer
eventually looks at the bug in more detail.

Presumably it has something to do with the specific way the five levels
of structures are nested here, and how things get inlined in this driver.
If the bug happened everywhere, it would likely have been found and
fixed earlier.

       Arnd