Re: [PATCH net-next] net: don't include ethtool.h from netdevice.h

From
Jakub Kicinski <kuba@kernel.org>
Date
2020-11-20 22:48:48
Also in
linux-rdma, netdev
Reply to
Johannes Berg, 2020-11-20
On Fri, 20 Nov 2020 23:28:28 +0100 Johannes Berg wrote:
On Fri, 2020-11-20 at 14:13 -0800, Jakub Kicinski wrote:
quoted
linux/netdevice.h is included in very many places, touching any
of its dependecies causes large incremental builds.

Drop the linux/ethtool.h include, linux/netdevice.h just needs
a forward declaration of struct ethtool_ops.

Fix all the places which made use of this implicit include.  
quoted
 include/net/cfg80211.h                                   | 1 +  
Sounds good to me, thanks. Will still cause all wireless drivers to
rebuild this way though. Maybe I'll see later if something can be done
about that.

Acked-by: Johannes Berg <johannes@sipsolutions.net>
Same for RDMA, sadly. Both need the firmware version string length.

One simple way to narrow things down would be to include only the uapi
version. Or we can duplicate the define, AFAIR duplicate defines are ok
as long as they are identical.

But not sure it's worth it, I'm happy enough with the 2x reduction in
objects getting rebuilt :)
Thread (4 messages) 4 messages, 3 authors, last reply 2020-11-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help