Re: [PATCH v6 2/3] ath11k: copy ce service configs to hw_params

akolli@codeaurora.org writes:

On 2020-09-07 15:28, Kalle Valo wrote:

quoted

Anilkumar Kolli [off-list ref] writes:

quoted

No functional changes, added target ce service configurations to
hw_params.

Signed-off-by: Anilkumar Kolli <redacted>

[...]

quoted

--- a/drivers/net/wireless/ath/ath11k/core.c
+++ b/drivers/net/wireless/ath/ath11k/core.c

@@ -812,12 +812,6 @@ int ath11k_core_init(struct ath11k_base *ab)
 		return ret;
 	}

-	ret = ath11k_init_hw_params(ab);
-	if (ret) {
-		ath11k_err(ab, "failed to get hw params %d\n", ret);
-		return ret;
-	}

This is very suspicious.

ath11k_core_pre_init() is calling ath11k_init_hw_params(), again
calling same function in ath11k_core_init() is not needed.

Will send this as a new patch ?

Yes, please send this in a new patch with a proper commit log explaining
the situation.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches