Re: [PATCH] nl80211: Add HE UL MU fixed rate setting

On Thu, 2020-05-28 at 15:43 -0700, Muna Sinada wrote:

This patch adds nl80211 definitions, policies and parsing code required
to pass HE UL MU fixed rate settings.

This seems to apply now, but doesn't compile. Also,

 	[NL80211_TXRATE_HE_LTF] = NLA_POLICY_RANGE(NLA_U8,
 						   NL80211_RATE_INFO_HE_1XLTF,
 						   NL80211_RATE_INFO_HE_4XLTF),
+	[NL80211_TXRATE_HE_UL] = {
+		.type = NLA_EXACT_LEN,
+		.len = sizeof(struct nl80211_txrate_he),
+	},

Please modernize that (there's a macro).

+		if (tb[NL80211_TXRATE_HE_UL] &&
+		    !he_set_mcs_mask(info, sband,
+				     nla_data(tb[NL80211_TXRATE_HE_UL]),
+				     mask->control[band].he_ul_mcs))
+			return -EINVAL;

And please add an netlink extack error message here.

johannes