Thread (2 messages) 2 messages, 2 authors, 2020-07-15

[PATCH] net: zydas: remove needless check before usb_free_coherent()

STALE2269d LANDED

From: Chen Ni <hidden>
Date: 2020-06-30 07:08:07
Also in: lkml, netdev
Subsystem: the rest, zd1211rw wireless driver · Maintainer: Linus Torvalds

Landed in mainline as 4f3ebd6fb680 on 2020-07-15.

From: Xu Wang <redacted>

usb_free_coherent() is safe with NULL addr and this check is
not required.

Signed-off-by: Xu Wang <redacted>
---
 drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
index 8ff0374126e4..65b5985ad402 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_usb.c
@@ -600,9 +600,7 @@ void zd_usb_disable_int(struct zd_usb *usb)
 	dev_dbg_f(zd_usb_dev(usb), "urb %p killed\n", urb);
 	usb_free_urb(urb);
 
-	if (buffer)
-		usb_free_coherent(udev, USB_MAX_EP_INT_BUFFER,
-				  buffer, buffer_dma);
+	usb_free_coherent(udev, USB_MAX_EP_INT_BUFFER, buffer, buffer_dma);
 }
 
 static void handle_rx_packet(struct zd_usb *usb, const u8 *buffer,
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help