Re: [PATCH 1/2] dt: bindings: Add new regulator as optional property for WCN3990
From: Doug Anderson <dianders@chromium.org>
Date: 2020-06-26 21:47:13
Also in:
linux-devicetree, lkml
Hi, On Fri, Jun 26, 2020 at 11:02 AM Rakesh Pillai [off-list ref] wrote:
Add an additional regulator supply as an optional property for WCN3990. Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.1-01040-QCAHLSWMTPLZ-1 Signed-off-by: Rakesh Pillai <redacted> --- Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Overall though: aren't you missing a whole lot of CCs? Have you tried using get_maintainer?
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt index 65ee68e..b7188d3 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt@@ -65,7 +65,8 @@ Optional properties: the length can vary between hw versions. - <supply-name>-supply: handle to the regulator device tree node optional "supply-name" are "vdd-0.8-cx-mx", - "vdd-1.8-xo", "vdd-1.3-rfa" and "vdd-3.3-ch0". + "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0" + and "vdd-3.3-ch1".
nit that could probably be fixed by maintainer when applying: missing comma at the end of "vdd-3.3-ch0" I will also note that this file is in dire need of being converted to yaml. Pretty soon I think people are going to start disallowing changes to the bindings that haven't been converted to yaml so you probably want to get a jump start on it so future patches aren't stalled. In any case: Reviewed-by: Douglas Anderson <dianders@chromium.org>