Re: [PATCH net-next 1/2] ath10k: fix gcc-10 zero-length-bounds warnings
From: Kalle Valo <hidden>
Date: 2020-05-12 07:33:53
Also in:
lkml, netdev
Arnd Bergmann [off-list ref] wrote:
gcc-10 started warning about out-of-bounds access for zero-length
arrays:
In file included from drivers/net/wireless/ath/ath10k/core.h:18,
from drivers/net/wireless/ath/ath10k/htt_rx.c:8:
drivers/net/wireless/ath/ath10k/htt_rx.c: In function 'ath10k_htt_rx_tx_fetch_ind':
drivers/net/wireless/ath/ath10k/htt.h:1683:17: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct htt_tx_fetch_record[0]' [-Wzero-length-bounds]
1683 | return (void *)&ind->records[le16_to_cpu(ind->num_records)];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/wireless/ath/ath10k/htt.h:1676:29: note: while referencing 'records'
1676 | struct htt_tx_fetch_record records[0];
| ^~~~~~~
Make records[] a flexible array member to allow this, moving it behind
the other zero-length member that is not accessed in a way that gcc
warns about.
Fixes: 22e6b3bc5d96 ("ath10k: add new htt definitions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kalle Valo <redacted>2 patches applied to ath-next branch of ath.git, thanks. 9f12bebd512c ath10k: fix gcc-10 zero-length-bounds warnings 32221df6765b ath10k: fix ath10k_pci struct layout -- https://patchwork.kernel.org/patch/11538233/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches