Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro
From: "andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>
Date: 2019-05-10 14:34:22
Also in:
alsa-devel, cgroups, dri-devel, intel-gfx, kvm, linux-arm-kernel, linux-clk, linux-fbdev, linux-gpio, linux-ide, linux-integrity, linux-mm, linux-mmc, linux-omap, linux-pci, linux-pm, linux-rockchip, linux-security-module, linux-tegra, linux-usb, linuxppc-dev, lkml, netdev
On Fri, May 10, 2019 at 09:15:27AM +0000, Ardelean, Alexandru wrote:
On Wed, 2019-05-08 at 16:22 +0300, Alexandru Ardelean wrote:quoted
On Wed, 2019-05-08 at 15:18 +0200, Greg KH wrote:quoted
On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote:quoted
On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote:
quoted
quoted
quoted
Can you split include/linux/ change from the rest?That would break the build, why do you want it split out? This makes sense all as a single patch to me.Not really. It would be just be the new match_string() helper/macro in a new commit. And the conversions of the simple users of match_string() (the ones using ARRAY_SIZE()) in another commit.I should have asked in my previous reply. Leave this as-is or re-formulate in 2 patches ?
Depends on on what you would like to spend your time: collecting Acks for all pieces in treewide patch or send new API first followed up by per driver / module update in next cycle. I also have no strong preference. And I think it's good to add Heikki Krogerus to Cc list for both patch series, since he is the author of sysfs variant and may have something to comment on the rest. -- With Best Regards, Andy Shevchenko