Thread (6 messages) 6 messages, 5 authors, 2019-02-01

Re: [PATCH] rtlwifi: rtl818x: fix indentation issue

flat view

From: Joe Perches <joe@perches.com>
Date: 2019-01-17 19:29:53
Also in: kernel-janitors, lkml, netdev

On Thu, 2019-01-17 at 15:28 +0000, Colin King wrote:
From: Colin Ian King <redacted>

There is a statement that is indented too deeply. Fix this.
Thanks.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
[]
quoted hunk ↗ jump to hunk
@@ -803,7 +803,7 @@ static void rtl8180_config_cardbus(struct ieee80211_hw *dev)
 		rtl818x_iowrite16(priv, FEMR_SE, 0xffff);
 	} else {
 		reg16 = rtl818x_ioread16(priv, &priv->map->FEMR);
-			reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
+		reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
 		rtl818x_iowrite16(priv, &priv->map->FEMR, reg16);
 	}
trivia:

It sure looks as if there could be some rather useful
conversions of magic bits to constants one day.


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help