Thread (5 messages) 5 messages, 3 authors, 2019-01-31

Re: [PATCH] rtlwifi: remove set but not used variable 'cmd_seq'

From: Pkshih <pkshih@realtek.com>
Date: 2019-01-30 01:32:08
Also in: netdev

On Tue, 2019-01-29 at 14:03 +0800, YueHaibing wrote:
+cc netdev@vger.kernel.org

On 2019/1/29 13:57, YueHaibing wrote:
quoted
ping...

On 2018/9/11 20:12, YueHaibing wrote:
quoted
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/realtek/rtlwifi/base.c: In function
'rtl_c2h_content_parsing':
quoted
quoted
drivers/net/wireless/realtek/rtlwifi/base.c:2313:13: warning:
 variable 'cmd_seq' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <redacted>
Thanks for your fix.

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

quoted
quoted
---
 drivers/net/wireless/realtek/rtlwifi/base.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c
b/drivers/net/wireless/realtek/rtlwifi/base.c
quoted
quoted
index f4122c8..92b6918 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -2310,11 +2310,10 @@ static void rtl_c2h_content_parsing(struct
ieee80211_hw *hw,
quoted
quoted
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 	struct rtl_hal_ops *hal_ops = rtlpriv->cfg->ops;
 	const struct rtl_btc_ops *btc_ops = rtlpriv->btcoexist.btc_ops;
-	u8 cmd_id, cmd_seq, cmd_len;
+	u8 cmd_id, cmd_len;
 	u8 *cmd_buf = NULL;
 
 	cmd_id = GET_C2H_CMD_ID(skb->data);
-	cmd_seq = GET_C2H_SEQ(skb->data);
 	cmd_len = skb->len - C2H_DATA_OFFSET;
 	cmd_buf = GET_C2H_DATA_PTR(skb->data);


.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help