Thread (40 messages) 40 messages, 4 authors, 2019-03-08

Re: [PATCH 12/24] mac80211: ignore NullFunc frames in the duplicate detection

From: Coelho, Luciano <hidden>
Date: 2018-12-18 00:55:32
Also in: stable

On Sat, 2018-12-15 at 19:31 +0200, Emmanuel Grumbach wrote:
On Sat, Dec 15, 2018 at 11:20 AM Luca Coelho [off-list ref] wrote:
quoted
From: Emmanuel Grumbach <redacted>

NullFunc packets should never be duplicate just like
QoS-NullFunc packets.

We saw a client that enters / exits power save with
NullFunc frames (and not with QoS-NullFunc) despite the
fact that the association supports HT.
This specific client also re-uses a non-zero sequence number
for different NullFunc frames.
At some point, the client had to send a retransmission of
the NullFunc frame and we dropped it, leading to a
misalignment in the power save state.
Fix this by never consider a NullFunc frame as duplicate,
just like we do for QoS NullFunc frames.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=201449
This has already been sent, it is in net.git already :)
Oops, sorry, my bad.  I obviously forgot to look it up before sending.

--
Cheers,
Luca.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help