Thread (37 messages) 37 messages, 6 authors, 2019-03-19

Re: [PATCH v2 1/3] rt2x00: use ratelimited variants dev_warn/dev_err

From: Joe Perches <joe@perches.com>
Date: 2018-12-21 11:19:37

On Thu, 2018-12-20 at 16:16 +0100, Stanislaw Gruszka wrote:
quoted hunk ↗ jump to hunk
As reported by Randy we can overwhelm logs on some USB error conditions.
To avoid that use dev_warn_ratelimited() and dev_err_ratelimitd().

Reported-and-tested-by: Randy Oostdyk <redacted>
Signed-off-by: Stanislaw Gruszka <redacted>
---
 drivers/net/wireless/ralink/rt2x00/rt2x00.h | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00.h b/drivers/net/wireless/ralink/rt2x00/rt2x00.h
[]
quoted hunk ↗ jump to hunk
@@ -65,14 +65,19 @@
 /* Utility printing macros
  * rt2x00_probe_err is for messages when rt2x00_dev is uninitialized
  */
+#define wiphy_err_ratelimited(wiphy, format, args...)		\
+	dev_err_ratelimited(&(wiphy)->dev, format, ##args)
+#define wiphy_warn_ratelimited(wiphy, format, args...)		\
+	dev_warn_ratelimited(&(wiphy)->dev, format, ##args)
+
These should probably be generic in include/net/cfg80211.h

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help