Thread (11 messages) 11 messages, 3 authors, 2018-09-30

Re: [RFC 0/4] mt76x0: phy/rf fixups for PCIe

From: Lorenzo Bianconi <hidden>
Date: 2018-09-30 19:12:07 

On 2018-09-27 10:37, Stanislaw Gruszka wrote:
quoted
This is RFC for now, especially I'm interesting if patch 3 and 4
is direction we should go.

This is on top of Lorenzo github mt7610ev5 branch.
Looks good to me.

Thanks,

- Felix
Hi Stanislaw,

I tested this series and it works fine, so feel free to add my
'tested-by' when you submit the patchset.
I guess we should add a 'mt76_is_usb()' check in rf_rr()/rf_wr(),
agree? Something like:

@@ -111,7 +111,8 @@
 static int
 rf_wr(struct mt76x02_dev *dev, u32 offset, u8 val)
 {
-    if (test_bit(MT76_STATE_MCU_RUNNING, &dev->mt76.state)) {
+    if (test_bit(MT76_STATE_MCU_RUNNING, &dev->mt76.state) &&
+        mt76_is_usb(dev)) {
         struct mt76_reg_pair pair = {
             .reg = offset,
             .value = val,
@@ -129,7 +130,8 @@
     int ret;
     u32 val;

-    if (test_bit(MT76_STATE_MCU_RUNNING, &dev->mt76.state)) {
+    if (test_bit(MT76_STATE_MCU_RUNNING, &dev->mt76.state) &&
+        mt76_is_usb(dev)) {
         struct mt76_reg_pair pair = {
             .reg = offset,
         };


Regards,
Lorenzo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help