Re: [PATCH v2 08/24] mt76: move mt76x2_wait_for_bbp in mt76x02-lib module
From: Stanislaw Gruszka <hidden>
Date: 2018-09-28 08:59:50
From: Stanislaw Gruszka <hidden>
Date: 2018-09-28 08:59:50
On Fri, Sep 28, 2018 at 08:40:01AM +0200, Lorenzo Bianconi wrote:
+static inline bool
+mt76x02_wait_for_txrx_active(struct mt76_dev *dev)
+{
+ return __mt76_poll_msec(dev, MT_MAC_STATUS,
+ MT_MAC_STATUS_TX | MT_MAC_STATUS_RX,
+ 0, 100);
+}The name is unfortunate, what we wait for is TX and RX become idle i.e. hardware do not perform any RX or TX (see for example mt76x2_mac_stop() ). I think this patch should be droped and we should just use mt76_poll_msec(MT_MAC_STATUS) directly, there is no real benefit for this function. Thanks Stanislaw