Thread (2 messages) flat view 2 messages, 2 authors, 2018-09-05

Re: [PATCH] mac80211: fix pending queue hang due to TX_DROP

From: Toke Høiland-Jørgensen <toke@toke.dk>
Date: 2018-09-05 15:21:53

Bob Copeland [off-list ref] writes:
In our environment running lots of mesh nodes, we are seeing the
pending queue hang periodically, with the debugfs queues file showing
lines such as:

    00: 0x00000000/348

i.e. there are a large number of frames but no stop reason set.

One way this could happen is if queue processing from the pending
tasklet exited early without processing all frames, and without having
some future event (incoming frame, stop reason flag, ...) to reschedule
it.

Exactly this can occur today if ieee80211_tx() returns false due to
packet drops or power-save buffering in the tx handlers.  In the
past, this function would return true in such cases, and the change
to false doesn't seem to be intentional.
Can confirm that this was not intentional; nice catch! :)

Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen <toke@toke.dk>

-Toke
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help