Thread (3 messages) 3 messages, 3 authors, 2018-08-09

Re: [PATCH] ssb: driver_gige: use true and false for boolean values

From: Michael Büsch <m@bues.ch>
Date: 2018-08-05 08:15:16
Also in: lkml

On Sat, 4 Aug 2018 19:04:53 -0500
"Gustavo A. R. Silva" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Return statements in functions returning bool should use true or false
instead of an integer value.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <redacted>
---
 drivers/ssb/driver_gige.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ssb/driver_gige.c b/drivers/ssb/driver_gige.c
index e973405..ebee6b0 100644
--- a/drivers/ssb/driver_gige.c
+++ b/drivers/ssb/driver_gige.c
@@ -242,7 +242,7 @@ static int ssb_gige_probe(struct ssb_device *sdev,
 bool pdev_is_ssb_gige_core(struct pci_dev *pdev)
 {
 	if (!pdev->resource[0].name)
-		return 0;
+		return false;
 	return (strcmp(pdev->resource[0].name, SSB_GIGE_MEM_RES_NAME) == 0);
 }
 EXPORT_SYMBOL(pdev_is_ssb_gige_core);
Looks good. Thanks.

Reviewed-by: Michael Buesch <m@bues.ch>


-- 
Michael

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help