-----Original Message-----
From: ath10k <redacted> On Behalf Of Ben
Greear
Sent: Tuesday, July 31, 2018 11:08 PM
To: Venkateswara Naralasetty <redacted>;
ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCHv2] ath10k : Fix channel survey dump
=20
On 07/31/2018 05:11 AM, Venkateswara Naralasetty wrote:

quoted

Channel active/busy time are showing incorrect(less than previous or
sometimes zero) for successive survey dump command.

example:
Survey data from wlan0
	frequency:                      5180 MHz [in use]
	channel active time:            54995 ms
	channel busy time:              432 ms
	channel receive time:           0 ms
	channel transmit time:          59 ms
Survey data from wlan0
	frequency:                      5180 MHz [in use]
	channel active time:            32592 ms
	channel busy time:              254 ms
	channel receive time:           0 ms
	channel transmit time:          0 ms

This patch fix this issue by assigning 'wmi_bss_survey_req_type'
as 'WMI_BSS_SURVEY_REQ_TYPE_READ' which accumulate survey data in

FW

quoted

and send survey data to driver upon the driver request. Wrap around is
taken care by FW.

hardware used : QCA9984
firmware ver  : ver 10.4-3.5.3-00057

=20
Have you tested this on other firmwares?  I am pretty sure that at least =

some

of them, probably 10.2, will have issues.
=20

I have tested this change with firmware version 10.2.4-1.0-00036 (hw used Q=
CA988x) as well it's working fine for me without any issues.
=20

Maybe you could make this change specific to certain firmware that is kno=

wn

to work with the change?
=20
Thanks,
Ben
=20

quoted

Signed-off-by: Venkateswara Naralasetty <redacted>
---
v2:
 * updated commit log.

 drivers/net/wireless/ath/ath10k/mac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c

b/drivers/net/wireless/ath/ath10k/mac.c
index f068e2b..db93ab1 100644

--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c

@@ -6837,7 +6837,7 @@ ath10k_mac_update_bss_chan_survey(struct

ath10k *ar,

quoted

 				  struct ieee80211_channel *channel)  {
 	int ret;
-	enum wmi_bss_survey_req_type type =3D

WMI_BSS_SURVEY_REQ_TYPE_READ_CLEAR;

quoted

+	enum wmi_bss_survey_req_type type =3D

WMI_BSS_SURVEY_REQ_TYPE_READ;

quoted

 	lockdep_assert_held(&ar->conf_mutex);

=20
=20
--
Ben Greear [off-list ref]
Candela Technologies Inc  http://www.candelatech.com
=20
=20
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k