Re: [RFC v2 2/4] mac80211: Add airtime accounting and scheduling to TXQs
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-08-29 11:40:01
On Mon, 2018-07-09 at 18:37 +0200, Toke Høiland-Jørgensen wrote:
quoted hunk ↗ jump to hunk
@@ -427,6 +428,8 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata, sta->cparams.interval = MS2TIME(100); sta->cparams.ecn = true; + sta->airtime.weight = 1;
Perhaps it might be useful to start with a higher default (even something like 1<<8) as that would allow adjusting up/down single stations, without having to adjust all stations and listening to new additions to adjust them quickly etc? Theoretically this doesn't really matter, but from a practical POV it may be easier to leave them all at the default and just adjust the ones that need adjustment for some reason.
ieee80211_sta_register_airtime
Do we really need this? We already have at least TX status with airtime, for ieee80211_sta_tx_notify() and friends, and the station pointer in that context, so couldn't we piggy-back on this? At least WMM-AC already requires the driver to provide this. johannes