Re: [PATCH] mac80211: allow station search on AP/VLANs
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-08-14 14:41:35
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-08-14 14:41:35
On Tue, 2018-08-14 at 17:22 +0530, Manikanta Pubbisetty wrote:
On 8/14/2018 4:58 PM, Johannes Berg wrote:quoted
On Mon, 2018-07-30 at 11:50 +0530, Manikanta Pubbisetty wrote:quoted
When mac80211 receives a packet, we interate over the list of active interfaces to find the station(which transmitted the packet). Currently, station search is not allowed on AP/VLAN interface; since stations can also get mapped to AP/VLAN interfaces, they are worth considering for station search.I don't see how this makes sense. We use sta_info_get_bss() later, so any AP/AP_VLAN would be OK, so we don't need to try it twice for AP_VLAN?AP/VLANs are skipped currently, we don't even get to sta_info_get_bss() if the iftype is AP/VLAN. No?
Yes, we won't try anything for the AP_VLANs, but when we hit the AP we look up through everything, no? Or maybe not - the _bss() just means fallback to AP? Hmm. But even then I can't really see where this would apply? johannes