Thread (3 messages) 3 messages, 2 authors, 2018-08-29

Re: [PATCH v2] mac80211: do not aggregate frames if max_frags is set to one

From: Lorenzo Bianconi <hidden>
Date: 2018-08-29 23:11:06

Possibly related (same subject, not in this thread)

On Wed, 2018-08-29 at 21:03 +0200, Lorenzo Bianconi wrote:
quoted
Do not try to aggregate packets in a A-MSDU frame and add A-MSDU header
on the first packet if max_tx_fragments or max_amsdu_subframes are
set to one

Signed-off-by: Lorenzo Bianconi <redacted>
---
Changes since v1:
- rebased on top of mac80211 master branch
- removed ieee80211_amsdu_realloc_pad chunk
Don't you still have to account for the changed header length if the
second one fails or something?
That has been fixed by Sara's patch since now we add the pad directly
on the head of the
subsequent subframes (not to the tail of the first one). Am I missing something?

Regards,
Lorenzo
You said you wanted to account for the pad bytes - which now aren't
there - but didn't that also take the changed header of the first
subframe into account?

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help