Thread (11 messages) 11 messages, 5 authors, 2018-08-28

Re: [Regression]BCM4312 is broken in kernel 4.18[Root cause found]

From: prabhu <hidden>
Date: 2018-08-26 11:05:14

Larry,

Upgrading the firmware didn't fix the issue.

The patch fixes it. My system has been running without any issues
since yesterday.
On Fri, Aug 24, 2018 at 9:45 PM Larry Finger [off-list ref] wr=
ote:
On 08/24/2018 03:23 AM, Kalle Valo wrote:
quoted
Michael B=C3=BCsch [off-list ref] writes:
quoted
On Thu, 23 Aug 2018 23:00:53 +0530
prabhu [off-list ref] wrote:
quoted
The following commits introduce this regression in 4.18
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co=
mmit/?id=3D66cffd6daab76caebab26eb803b92182414fc182
quoted
quoted
Ok. Kalle, can you please revert the commit
66cffd6daab76caebab26eb803b92182414fc182
?
Please submit a proper patch with an explanation why it needs to be
reverted.
Before doing a revert, let's see if we can keep the fix for open firmware=
, the
situation for which commit 66cffd6daab7 was "needed". I think the followi=
ng
quoted hunk ↗ jump to hunk
should do:
diff --git a/drivers/net/wireless/broadcom/b43/dma.c
b/drivers/net/wireless/broadcom/b43/dma.c
index 6b0e1ec346cb..2c37366b3592 100644
--- a/drivers/net/wireless/broadcom/b43/dma.c
+++ b/drivers/net/wireless/broadcom/b43/dma.c
@@ -1519,12 +1519,14 @@ void b43_dma_handle_txstatus(struct b43_wldev *de=
v,
                 } else {
                         /* More than a single header/data pair were miss=
ed.
                          * Report this error, and reset the controller t=
o
-                        * revive operation.
+                        * revive operation. If running the open-source
+                        * firmware, then do a restart.
                          */
                         b43dbg(dev->wl,
                                "Out of order TX status report on DMA rin=
g %d.
Expected %d, but got %d\n",
                                ring->index, firstused, slot);
-                       b43_controller_restart(dev, "Out of order TX");
+                       if (dev->fw.opensource)
+                               b43_controller_restart(dev, "Out of order=
 TX");
                         return;
                 }
         }

At the moment, I am working with prabhu to see if upgrading his firmware =
will
help his problem with no change in the driver. If not, then I will have h=
im test
this patch.

Larry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help