On Wed, 2018-08-15 at 18:50 -0700, pradeepc@codeaurora.org wrote:

quoted

All you describe above is really a driver bug - it shouldn't have
enabled it to start with?

Sure.. But isn't it justifiable for drivers/firmware choosing to enable
ftm responder by default when there is no way for userspace to specify 
this parameter?

No? FTM needs higher-level configuration/advertisement, so how could the
driver/firmware enable it when it's not supposed to be?

I really do think this is a driver bug.

Nothing stopped you from submitting these patches months/years ago when
the capability was first added to the firmware, after all.

quoted

This makes sense anyway. Funny you should post this within hours of me
doing the same, basically.

Sorry, I missed your patches before posting mine :)

No worries.

quoted

I have no objection to your approach, though I guess it'd be nice if 
you
could take a look at the statistics I have exposed and see if those
makes sense or if additional ones are desirable for you, and then we 
can combine the work that way, i.e. have your configuration and our stats?

I looked at the patch you posted and this makes sense. I will try to 
align ath10k driver changes with your approach.

I tend to actually like your patch better for configuration - no new
command, though it is, I think, lacking configuration of the necessary
elements (where do you take the LCI/Civic location from?).

johannes