Re: [RFC v2] ath10k: report tx rate using ieee80211_tx_status()
From: Kalle Valo <hidden>
Date: 2018-08-21 11:05:15
Anilkumar Kolli [off-list ref] writes:
On 2018-04-25 19:33, Kalle Valo wrote:quoted
Anilkumar Kolli [off-list ref] writes:quoted
On 2018-04-24 13:32, Kalle Valo wrote:quoted
Anilkumar Kolli [off-list ref] writes:quoted
Mesh path metric needs txrate information from ieee80211_tx_status() call but in ath10k there is no mechanism to report tx rate information via ieee80211_tx_status(), the rate is only accessible via sta_statiscs() op. Per peer stats has tx rate info available, this patch stores per peer last tx rate and updates the tx rate info structures in tx completition. The rate updated in ieee80211_tx_status() is not exactly for the last transmitted frame instead the rate is from one of the previous frames. Per peer txrate information is updated through per peer statistics and is available for QCA9888/QCA9984/QCA4019/QCA998X only Tested on QCA9984 with firmware-5.bin_10.4-3.5.3-00053 Tested on QCA998X with firmware-5.bin_10.2.4-1.0-00036 Signed-off-by: Anilkumar Kolli <redacted>BTW, your name in patchwork is "akolli@codeaurora.org" but it should be "Anilkumar Kolli" and that's why my script uses the wrong name. Please fix it by registering to patchwork as it's possible to change your name during registration, but only one time. If that doesn't work then send a request to helpdesk@kernel.org and the admins will fix it.I registered and updated name in the patchwork website.It seems that your name still is "akolli@codeaurora.org" in the Submitter field: https://patchwork.kernel.org/patch/10353959/ An example how it should look like: https://patchwork.kernel.org/patch/10359823/ I think you need to contact helpdesk now and ask them to fix it.quoted
Do I need to resend the patch ?No need to resend because of this.Hi Kalle, Do you have any comments on this RFC. Shall I submit as a patch ?
I have some questions about it but I haven't had a chance to look at in detail yet, hopefully later this week. -- Kalle Valo