On Tue, 2018-08-28 at 23:07 +0200, Lorenzo Bianconi wrote:

quoted

Do not try to aggregate packets in a A-MSDU frame if max_tx_fragments
or max_amsdu_subframes is set to 1.

Yeah that seems valid.

quoted

Moreover take into account
tail padding added on the first frame into flow backlog if
ieee80211_amsdu_realloc_pad routine on the second frame fails.

That's not really right - the padding shouldn't have been added to the
first subframe in the first place as the last one shouldn't have padding
at all. There's also a separate bug in that the A-MSDU subframe length
should NOT include the padding.

Assuming the A-MSDU subframe is composed by two packets, the last one
must not contain padding, is my understanding correct?

My colleague Sara (CC'ed now) has a patch to fix all of this (we just
did that this morning). I'll send it out tomorrow morning. Can I bother
you to try that?

Sure, no worries :)

We'd have to fix the first point independently though, or I guess we can
roll that into our bugfix too, which would you prefer?

johannes

If the patch is already done I can add the fix for the first point on
top of it, does it sound good?

Regards,
Lorenzo