Re: [PATCH 03/10] atmel: hide unused procfs helpers
From: Randy Dunlap <hidden>
Date: 2018-07-27 15:45:03
Also in:
lkml, netdev
Possibly related (same subject, not in this thread)
- 2018-07-31 · Re: [PATCH 03/10] atmel: hide unused procfs helpers · Kalle Valo <hidden>
- 2018-07-13 · Re: [PATCH 03/10] atmel: hide unused procfs helpers · YueHaibing <hidden>
- 2018-07-13 · [PATCH 03/10] atmel: hide unused procfs helpers · YueHaibing <hidden>
On 07/27/2018 02:24 AM, Kalle Valo wrote:
(fixing top posting) YueHaibing [off-list ref] writes:quoted
On 2018/7/13 14:46, YueHaibing wrote:quoted
When CONFIG_PROC_FS isn't set, gcc warning this: drivers/net/wireless/atmel/atmel.c:1402:12: warning: ‘atmel_proc_show’ defined but not used [-Wunused-function] static int atmel_proc_show(struct seq_file *m, void *v) ^ fix this by adding #ifdef around it. Signed-off-by: YueHaibing <redacted>pls ignore this,my bad.Why should I drop this? Does the patch have something wrong which I'm missing? I'm asking because I prefer this over Randy's version: https://patchwork.kernel.org/patch/10512913/
Take it. I don't mind. -- ~Randy