Re: [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name
From: Dan Carpenter <hidden>
Date: 2018-07-19 10:10:19
On Thu, Jul 19, 2018 at 04:15:01AM +0530, Ajay Singh wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 85af365..8e71c28 100644 --- a/drivers/staging/wilc1000/wilc_wlan.c +++ b/drivers/staging/wilc1000/wilc_wlan.c@@ -850,13 +850,13 @@ static void wilc_wlan_handle_isr_ext(struct wilc *wilc, u32 int_status) if (wilc->rx_buffer) buffer = &wilc->rx_buffer[offset]; else - goto _end_; + goto end;
This isn't related to your patch but this goto doesn't appear to make any sort of sense. I have no idea what was intended.
wilc->hif_func->hif_clear_int_ext(wilc,
DATA_INT_CLR | ENABLE_RX_VMM);
ret = wilc->hif_func->hif_block_rx_ext(wilc, 0, buffer, size);
-_end_:
+end:
if (ret) {
offset += size;
wilc->rx_buffer_offset = offset;regards, dan carpenter