On 2018-07-06 17:10, Johannes Berg wrote:

On Wed, 2018-07-04 at 11:39 +0530, Tamizh chelvam wrote:

quoted

On 2018-06-29 14:59, Johannes Berg wrote:

quoted

On Wed, 2018-06-13 at 16:15 +0530, Tamizh chelvam wrote:

quoted

+ * @NL80211_ATTR_STA_MON: Station's connection monitor configuration
in a
+ *	nested attribute with %NL80211_ATTR_STA_MON_* sub-attributes.

Can't we reuse the existing attributes in this nesting?

This new attributes introduced as per the previous discussion.
https://patchwork.kernel.org/patch/10240697/
Is my understanding correct ?

Yeah ok ... I'm thinking perhaps we could share some part of it, but
it's not really worth making it more complex due to that.

Sure, i'll reuse those cqm attributes and event notification enum as 
well.

quoted

quoted

Wait, you went to all this effort in the first patch and now you don't
add this to the list?

No, the list and the rssi_config structure is for multi threshold 
value
and not for single threshold.

Yeah, though I'm still not sure why we need the single threshold thing
at all.

For taking steering kind of decision single threshold value can be used 
to monitor
the station's rssi.

List should always be a superset.

I believe superset you meant will accept a signle threshold 
configuration also from user ?
If so, we can remove the single threshold api implementation.

Thanks,
Tamizh.