Re: [PATCH 1/3] net: use BIT_ULL for NL80211_STA_INFO_* attribute types

From
Johannes Berg <johannes@sipsolutions.net>
Date
2018-06-13 12:42:58
Reply to
Omer Efrat, 2018-06-06
On Wed, 2018-06-06 at 11:26 +0300, Omer Efrat wrote:
Since 'filled' member in station_info changed to u64, BIT_ULL macro
should be used with NL80211_STA_INFO_* attribute types instead of BIT.

The BIT macro uses unsigned long type which some architectures handle as 32bit
and this results in compilation warnings such as:

net/mac80211/sta_info.c:2223:2: warning: left shift count >= width of type
  sinfo->filled |= BIT(NL80211_STA_INFO_TID_STATS);
  ^

Signed-off-by: Omer Efrat <redacted>
Looks good, but can you please split it? I don't want to take batman
changes, and they probably don't want to take my mac80211 - unless davem
decides to take it all?

johannes
Thread (5 messages) 5 messages, 3 authors, last reply 2018-06-13
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help