On 06/18/2018 01:46 PM, Johannes Berg wrote:

On Thu, 2018-05-31 at 08:52 -0700, Ben Greear wrote:

quoted

On 05/31/2018 02:06 AM, vnaralas@codeaurora.org wrote:

quoted

On 2018-05-23 15:24, Johannes Berg wrote:

quoted

On Tue, 2018-05-22 at 14:45 +0530, Venkateswara Naralasetty wrote:

quoted

This patch provides support to send accumulated survey data to
user if low level drivers provides non-accumulated survey data.

I think the commit log should say what you need this for?

It's simultaneously a new flag, and a lot of code, but it's not clear
what the point is?

johannes

I will sent next version of patch with updated commit log.

Providing you the earlier discussion of this patch to give quick overview about this patch.
https://patchwork.kernel.org/patch/9701459/

It is simple to fix the firmware, it just has several bugs related to clearing the
accumulator as well as the 'real' values.  If you can find a QCA firmware engineer
that will accept patches I can show them how to fix this easily.  I recently
fixed this in my wave-1 firmware.  I posted patches to the ath10k driver to
support this a week or so ago, but not sure if Kalle will apply them.

That would be nicer even, but I guess we still have to worry about older
firmware? Perhaps not for survey support? Dunno.

Obviously less code is better, but I can't really say how easy it would
be to get firmware updates rolled out to people who'd need them ...

quoted

And, it is likely that even if you don't use the 'clear' option, you are going to
get wraps in the firmware and that will just be other harder to debug bugs.

You have to use clear if you don't accumulate completely in fw, no?

At least some firmware is broken in numerous ways, and there is no clear way to
tell which firmware is broken how as far as I can tell.  It does appear to be fixed in
recent 10.4 (wave-2) firmware, so maybe they will fix 10.2 as well.

Thanks,
Ben

-- 
Ben Greear [off-list ref]
Candela Technologies Inc  http://www.candelatech.com