Thread (1 message) 1 message, 1 author, 2018-05-11

Re: [PATCH 4.17 2/2] ssb: make SSB_PCICORE_HOSTMODE depend on SSB = y

From: Kalle Valo <hidden>
Date: 2018-05-11 10:18:36
Also in: lkml

Larry Finger [off-list ref] writes:
On 05/10/2018 06:14 AM, Rafa=C5=82 Mi=C5=82ecki wrote:
quoted
From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>

SSB_PCICORE_HOSTMODE protects MIPS specific code that calls not exported
symbols pcibios_enable_device and register_pci_controller. This code is
supposed to be compiled only with ssb builtin.

This fixes:
ERROR: "pcibios_enable_device" [drivers/ssb/ssb.ko] undefined!
ERROR: "register_pci_controller" [drivers/ssb/ssb.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1

Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
This patch needs a "Reported-by: Matt Redfearn [off-list ref]".

Applying both patches leads to a correct configuration for PCI. I
cannot test on my present hardware, but the patches seem to be
correct.

Reviewed-by: Larry Finger <redacted>

@Kalle: Please drop my patch from yesterday. This solution is much better.
Dropped, thanks for letting me know.

--=20
Kalle Valo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help