Alexei Starovoitov [off-list ref] writes:

On Wed, May 23, 2018 at 01:03:08PM +0200, Johannes Berg wrote:

quoted

On Wed, 2018-03-28 at 12:05 -0700, Alexei Starovoitov wrote:

quoted

fix iwlwifi_dev_ucode_error tracepoint to pass pointer to a table
instead of all 17 arguments by value.
dvm/main.c and mvm/utils.c have 'struct iwl_error_event_table'
defined with very similar yet subtly different fields and offsets.
tracepoint is still common and using definition of 'struct iwl_error_event_table'
from dvm/commands.h while copying fields.
Long term this tracepoint probably should be split into two.

It would've been nice to CC the wireless list for wireless related
patches ...

Ohh. I didn't realize that networking wireless doesn't fall under netdev.
I thought wireless folks are silent because they are embarrassed
by a function with 17 arguments.

Really, this is the level of discussion now? You don't even bother to CC
the driver maintainers and your first reaction is that they are just too
embarrassed to answer? Oh man...

But if you continue doing these kind of "drive-by cleanups" to a
subsystem you are not familiar with, at least don't assume anything and
instead use get_maintainer script to find the maintainers so that the
patches get reviewed and applied to the correct tree:

$ scripts/get_maintainer.pl --no-rolestats --no-git -f drivers/net/wireless/intel/iwlwifi/dvm/main.c
Johannes Berg [off-list ref]
Emmanuel Grumbach [off-list ref]
Luca Coelho [off-list ref]
Intel Linux Wireless [off-list ref]
Kalle Valo [off-list ref]
"David S. Miller" [off-list ref]
Daniel Borkmann [off-list ref]
Alexei Starovoitov [off-list ref]
Kees Cook [off-list ref]
linux-wireless@vger.kernel.org
netdev@vger.kernel.org
linux-kernel@vger.kernel.org

-- 
Kalle Valo