Thread (9 messages) flat view 9 messages, 4 authors, 2018-03-27

Re: [PATCH 1/3] ieee80211: Replace bit shifts with the BIT() macro for WLAN_CAPABILITY_*.

From: Quytelda Kahja <hidden>
Date: 2018-03-24 23:02:28
Also in: lkml

The "document" refers to the file in which the changes were made
('include/linux/ieee80211.h').

I tend to try to split my commits into the smallest logically related
changes possible, hence the three patch series.  This particular case
may be a little on the extreme side, but if the maintainer desires,
they can always squash them together or ask me to resubmit as one
patch.

On 3/24/18, Larry Finger [off-list ref] wrote:
On 03/23/2018 11:10 PM, Quytelda Kahja wrote:
quoted
It is neater and more consistent with the rest of the document to use the
BIT() macro from 'linux/bitops.h' to define the WLAN_CAPABILITY_*
bitmasks.  In the case of WLAN_CAPABILITY_DMG_TYPE_{IBSS, PBSS, AP},
bitshifting integers by 0 does nothing, so there is no reason to do it in
the code; replace these values with plain integers.

Signed-off-by: Quytelda Kahja <redacted>
In the commit message for all of these, what is the "document" to which you
refer?

I'm not quite sure why you split these changes into 3 parts, but I guess
that is OK.

Larry
-- 
Thank you,
Quytelda Kahja
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help