Re: [PATCH] firmware: add a function to load optional firmware v2
From: Kalle Valo <hidden>
Date: 2018-03-13 13:35:18
Also in:
lkml
Arend van Spriel [off-list ref] writes:
On 3/11/2018 5:05 PM, Andres Rodriguez wrote:quoted
quoted
Your patch series then should also have the driver callers who you want to modify to use this new API. Collect from the 802.11 folks the other drivers which I think they wanted changed as well.Arend, Kalle, would love to hear your feedback.I am not sure if it was ath10k, but Kalle will surely know. The other driver firing a whole batch of firmware requests is iwlwifi. These basically try to get latest firmware version and if not there try an older one.
Oh yeah, ath10k definitely needs this! It tries different firmware API versions from latest to older (firmware-6.bin, firmware-5.bin, firmware-4.bin and so on) to find a compatible firmware and the error messages from request_firmware() are constantly confusing the users, I think the latest query about these errors from last week on IRC. So having request_firmware_nowarn() (or similar) would help users a lot. We tried to workaround this by using request_firmware_direct() (which oddly doesn't print anything) but that caused issues with OpenWRT/LEDE: https://git.kernel.org/linus/c0cc00f250e1 And iwlwifi has a similar problem, adding Luca to the loop. -- Kalle Valo