Nevermind. round_up instead of DIV_ROUND_UP.

Bas Vermeulen


On 01-03-18 11:22, Bas Vermeulen wrote:

On 28-02-18 15:26, Lorenzo Bianconi wrote:

quoted

Fix the following sparse warning in mt7601u_efuse_physical_size_check:
- drivers/net/wireless/mediatek/mt7601u/eeprom.c:77:27: warning:
   Variable length array is used

Signed-off-by: Lorenzo Bianconi <redacted>
---
  drivers/net/wireless/mediatek/mt7601u/eeprom.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/mediatek/mt7601u/eeprom.c 

b/drivers/net/wireless/mediatek/mt7601u/eeprom.c
index da6faea092d6..a462064b5c91 100644

--- a/drivers/net/wireless/mediatek/mt7601u/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt7601u/eeprom.c

@@ -74,7 +74,7 @@ static int

  mt7601u_efuse_physical_size_check(struct mt7601u_dev *dev)
  {
      const int map_reads = DIV_ROUND_UP(MT_EFUSE_USAGE_MAP_SIZE, 16);
-    u8 data[map_reads * 16];
+    u8 data[round_up(MT_EFUSE_USAGE_MAP_SIZE, 16)];

Shouldn't this be u8 data[round_up(MT_EFUSE_USAGE_MAP_SIZE,16)*16]; to 
get the
same array size as before?

Bas Vermeulen

-- 
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.