Re: [PATCH v2] brcmfmac: Add support for getting nvram contents from EFI variables

Hi Hans,

I love your patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180319]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Hans-de-Goede/brcmfmac-Add-support-for-getting-nvram-contents-from-EFI-variables/20180319-164541
config: arm-tegra_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c: In function 'brcmf_fw_request_nvram_done':

quoted

drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:545:44: error: passing argument 1 of 'brcmf_fw_nvram_from_efi' from incompatible pointer type [-Werror=incompatible-pointer-types]

      else if ((data = brcmf_fw_nvram_from_efi(fwctx, &data_len)))
                                               ^~~~~
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: expected 'size_t * {aka unsigned int *}' but argument is of type 'struct brcmf_fw *'
    static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; }
               ^~~~~~~~~~~~~~~~~~~~~~~

quoted

drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:545:20: error: too many arguments to function 'brcmf_fw_nvram_from_efi'

      else if ((data = brcmf_fw_nvram_from_efi(fwctx, &data_len)))
                       ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c:525:12: note: declared here
    static u8 *brcmf_fw_nvram_from_efi(size_t *data_len) { return NULL; }
               ^~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/brcmf_fw_nvram_from_efi +545 drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c

   527	
   528	static void brcmf_fw_request_nvram_done(const struct firmware *fw, void *ctx)
   529	{
   530		struct brcmf_fw *fwctx = ctx;
   531		bool free_bcm47xx_nvram = false;
   532		bool kfree_nvram = false;
   533		u32 nvram_length = 0;
   534		void *nvram = NULL;
   535		u8 *data = NULL;
   536		size_t data_len;
   537	
   538		brcmf_dbg(TRACE, "enter: dev=%s\n", dev_name(fwctx->dev));
   539		if (fw && fw->data) {
   540			data = (u8 *)fw->data;
   541			data_len = fw->size;
   542		} else {
   543			if ((data = bcm47xx_nvram_get_contents(&data_len)))
   544				free_bcm47xx_nvram = true;
 > 545			else if ((data = brcmf_fw_nvram_from_efi(fwctx, &data_len)))
   546				kfree_nvram = true;
   547			else if (!(fwctx->flags & BRCMF_FW_REQ_NV_OPTIONAL))
   548				goto fail;
   549		}
   550	
   551		if (data)
   552			nvram = brcmf_fw_nvram_strip(data, data_len, &nvram_length,
   553						     fwctx->domain_nr, fwctx->bus_nr);
   554	
   555		if (free_bcm47xx_nvram)
   556			bcm47xx_nvram_release_contents(data);
   557		if (kfree_nvram)
   558			kfree(data);
   559	
   560		release_firmware(fw);
   561		if (!nvram && !(fwctx->flags & BRCMF_FW_REQ_NV_OPTIONAL))
   562			goto fail;
   563	
   564		fwctx->done(fwctx->dev, 0, fwctx->code, nvram, nvram_length);
   565		kfree(fwctx);
   566		return;
   567	
   568	fail:
   569		brcmf_dbg(TRACE, "failed: dev=%s\n", dev_name(fwctx->dev));
   570		release_firmware(fwctx->code);
   571		fwctx->done(fwctx->dev, -ENOENT, NULL, NULL, 0);
   572		kfree(fwctx);
   573	}
   574	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation