Re: [v5 4/8] rsi: add coex support
From: Kalle Valo <hidden>
Date: 2018-02-01 06:56:14
Also in:
linux-bluetooth
Amitkumar Karwar [off-list ref] writes:
From: Prameela Rani Garnepudi <redacted> With BT support, driver has to handle two streams of data (i.e. wlan and BT). Actual coex implementation is in firmware. Coex module just schedule the packets to firmware by taking them from the corresponding paths. Structures for module and protocol operations are introduced for this purpose. Protocol operations structure is global structure which can be shared among different modules. Initialization of coex and operating mode values is moved to rsi_91x_init(). Signed-off-by: Prameela Rani Garnepudi <redacted> Signed-off-by: Siva Rebbagondla <redacted> Signed-off-by: Amitkumar Karwar <redacted>
[...]
quoted hunk ↗ jump to hunk
@@ -270,6 +271,7 @@ struct rsi_common { u8 obm_ant_sel_val; int tx_power; u8 ant_in_use; + struct semaphore tx_bus_lock;
Do you really need to use semaphore? I think nowadays the preference is to use something other than semaphores. Also calling it tx_bus_lock is IMHO misleading, tx_bus_sema would be nicer. -- Kalle Valo