On Tue, Feb 27, 2018 at 03:31:11PM -0800, Kees Cook wrote:

On Tue, Feb 27, 2018 at 3:20 PM, Luis R. Rodriguez [off-list ref] wrote:

quoted

Currently fw_add_devm_name() returns 1 if the firmware cache
was already set. This makes it complicated for us to check for
correctness. It is actually non-fatal if the firmware cache
is already setup, so just return 0, and simplify the checkers.

Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>

That'll teach me to read all the patches first. ;)

Honestly, I'd just fold this into the prior patch: there's only one
caller and it's exactly about checking the return value.

Sounds good.

  Luis