On 2018-01-22 17:52, Johannes Berg wrote:

On Thu, 2018-01-18 at 18:10 +0530, Venkateswara Naralasetty wrote:

quoted

From: Bhagavathi Perumal S <redacted>

This patch provides support for users to get ack signal
strength of last transmitted by introducing new attribute
'NL80211_STA_INFO_ACK_SIGNAL'.

No real objection to the patch itself, but you should say *why* you
need this, and I'm not really sure I see much point in having the
signal strength of the very last ACK frame?

If user wants to get instant RSSI for the station which is ideal for 
long time, user can sent null frame and get RSSI form the ack of that 
null frame.

At least provide reasoning so other drivers can decide whether to
implement it or not.

quoted

+ * @NL80211_STA_INFO_ACK_SIGNAL: signal strength of the last ACK 
frame(u8, dBm)

more like s8, really.

I have taken reference from 'NL80211_STA_INFO_SIGNAL_AVG'.