Re: [PATCH v2 13/14] staging: wilc1000: rename Handle_Connect() to avoid camelCase
From: Ajay Singh <ajay.kathat@microchip.com>
Date: 2018-01-30 16:10:12
On Tue, 30 Jan 2018 17:40:31 +0300 Dan Carpenter [off-list ref] wrote:
On Tue, Jan 30, 2018 at 07:29:49PM +0530, Ajay Singh wrote:quoted
On Tue, 30 Jan 2018 02:13:53 +0800 kbuild test robot [off-list ref] wrote:quoted
The patch only change variable names to avoid the camelCase, didn't modify any extra code to dereference memory.You are responding to a robot and I think we all understood that this warning was there before you renamed the variables.
Thanks, got it.
quoted
I think, with the use of shorter variable name now memcpy() is taking 1 line instead of 3 lines. So, now line 937 has different code line(as code is swifted up by few lines).So because of that new potential NULL dereference error is popped up for same existing code. The code to validate dynamically allocated memory before access, will be include in separate patch to keep it segregated from variable names changes. I will rework on this patch and resend again.There is no need to re-work the patch.
Few of the patches for patch series are accepted and submitted to "linux-next". For now, will submit the a new patch series by including the remaining patches (changing commit subject line to avoid confusion from previous patches).
You are right that the NULL check should be added as a separate check. regards, dan carpenter
Regards, Ajay