Thread (10 messages) 10 messages, 2 authors, 2018-01-22

Re: [PATCH 3/4] mac80211: enable setting cqm config for AP mode

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-01-22 12:57:41

On Wed, 2018-01-17 at 13:01 +0530, tamizhr@codeaurora.org wrote:
+static void ieee80211_update_rssi_config(struct ieee80211_sub_if_data *sdata)
[...]
+	/* if AP, always tell the driver by checking beacon status */
+	if ((sdata->vif.type == NL80211_IFTYPE_AP ||
+	     sdata->vif.type == NL80211_IFTYPE_AP_VLAN ||
+	     sdata->vif.type == NL80211_IFTYPE_P2P_GO) &&
+	     !sdata->vif.bss_conf.enable_beacon)
nit: that line with !sdata should be indented one less, it doesn't
belong into the parenthesized expression.

Again though, this relies on a driver feature bit to not confuse the
driver.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help