Thread (3 messages) 3 messages, 2 authors, 2018-01-24

Re: [PATCH v2] mac80211_hwsim: don't use WQ_MEM_RECLAIM

From: Johannes Berg <johannes@sipsolutions.net>
Date: 2018-01-24 10:46:28

On Wed, 2018-01-24 at 10:39 +0100, Benjamin Beichler wrote:
sorry for introducing that error, but I'm a bit confused by the
workqueue documentation.
My assumption was, that deleting hwsim radios is reclaiming memory, and
since this queue does nothing else it would save/necessary to set this flag.

Maybe a hint in the documentation, that a work item on a WQ_MEM_RECLAIM
queue must not call flush of an !WQ_MEM_RECLAIM queue would be nice.
Maybe it's kind of obvious, but there is also a reminder not to forget
that flag, if a queue may have work items that reclaim memory
Yeah, honestly, I'm not really sure either. Clearly we can't set it,
but other drivers also set it...

I don't think it was *intended* for when you're freeing memory, since I
think reclaiming is what happens when you write out dirty buffers to
disk etc.

johannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help