Thread (5 messages) 5 messages, 3 authors, 2017-12-14

Re: [PATCH] wcn36xx: Add hardware scan offload support

From: Loic Poulain <hidden>
Date: 2017-12-11 08:58:26
Also in: linux-arm-msm

Hi Bjorn,

On 9 December 2017 at 01:34, Bjorn Andersson [off-list ref] wrote:
quoted
diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
[..]
quoted
+static int wcn36xx_smd_hw_scan_ind(struct wcn36xx *wcn, void *buf, size_t len)
+{
+     struct wcn36xx_hal_scan_offload_ind *rsp = buf;
+     struct cfg80211_scan_info scan_info = {};
+
+     if (len != sizeof(*rsp)) {
+             wcn36xx_warn("Corrupted delete scan indication\n");
+             return -EIO;
+     }
+
+     wcn36xx_dbg(WCN36XX_DBG_HAL, "scan indication (type %x)", rsp->type);
+
+     switch (rsp->type) {
+     case WCN36XX_HAL_SCAN_IND_FAILED:
+             scan_info.aborted = true;
+     case WCN36XX_HAL_SCAN_IND_COMPLETED:
+             mutex_lock(&wcn->scan_lock);
Grabbing this mutex with DEBUG_ATOMIC_SLEEP causes issues, but that's
because the locking in ind_smd_work() is to excessive. Will reply with a
fix for this.
Oops you're right, thanks for the patch.

Regards,
Loic
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help