Re: [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing
From: Arend van Spriel <arend.vanspriel@broadcom.com>
Date: 2017-12-11 09:55:18
Also in:
linux-devicetree
Possibly related (same subject, not in this thread)
- 2017-12-15 · Re: [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing · Rob Herring <hidden>
- 2017-12-11 · [PATCH] dt-bindings: net: wireless: Add sg parameters dts parsing · Chi-Hsien Lin <hidden>
On 12/11/2017 9:11 AM, Chi-Hsien Lin wrote:
quoted hunk
broken_sg_support, sd_head_align, and sd_sgentry_align are used in brcmfmac code but not configurable in dts file. Add the parsing logic. Now they can be configured like below in dts: brcm,broken_sg_support; brcm,sd_head_align = <4>; brcm,sd_sgentry_align = <4>; Signed-off-by: Chi-hsien Lin <redacted> --- .../devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt | 8 ++++++++ 1 file changed, 8 insertions(+)diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt index 86602f2..4d42f0d 100644 --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm43xx-fmac.txt@@ -17,6 +17,11 @@ Optional properties: When not specified the device will use in-band SDIO interrupts. - interrupt-names : name of the out-of-band interrupt, which must be set to "host-wake". + - broken_sg_support : flag for broken sg list support of SDIO host controller. + Set this to true if the SDIO host controller has higher align + requirement than 32 bytes for each scatterlist item.
In DT context, this does not characterize the device but as described it is about the SDIO host controller. I think the same applies to the properties below, but not entirely sure about that.
+ - sg_head_align : alignment requirement for start of data buffer. + - sg_sgentry_align : length alignment requirement for each sg entry.
Regards, Arend