Re: [PATCH][next] wcn36xx: remove redundant assignment to msg_body.min_ch_time
From: Bjorn Andersson <hidden>
Date: 2017-12-26 20:13:17
Also in:
kernel-janitors, lkml, netdev
On Tue 19 Dec 09:04 PST 2017, Colin King wrote:
From: Colin Ian King <redacted>
msg_body.min_ch_time is being assigned twice; remove the redundant
first assignment.
Detected by CoverityScan, CID#1463042 ("Unused Value")
Happy to see Coverity working for us :)
This should have had a:
Fixes: 2f3bef4b247e ("wcn36xx: Add hardware scan offload support")
quoted hunk ↗ jump to hunk
Signed-off-by: Colin Ian King <redacted> --- drivers/net/wireless/ath/wcn36xx/smd.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c index 2914618a0335..bab2eca5fcac 100644 --- a/drivers/net/wireless/ath/wcn36xx/smd.c +++ b/drivers/net/wireless/ath/wcn36xx/smd.c@@ -625,7 +625,6 @@ int wcn36xx_smd_start_hw_scan(struct wcn36xx *wcn, struct ieee80211_vif *vif, INIT_HAL_MSG(msg_body, WCN36XX_HAL_START_SCAN_OFFLOAD_REQ); msg_body.scan_type = WCN36XX_HAL_SCAN_TYPE_ACTIVE; - msg_body.min_ch_time = 30; msg_body.min_ch_time = 100;
But I strongly suspect the second line is supposed to be max_ch_time. @Loic, do you agree? Regards, Bjorn