Thread (5 messages) 5 messages, 3 authors, 2017-12-07

Re: [PATCH 1/3] ath9k: remove stray backslash in Makefile

From: Jakub Kicinski <hidden>
Date: 2017-11-28 03:35:26
Also in: lkml, netdev

On Mon, 27 Nov 2017 18:56:21 +0100, Matthias Schiffer wrote:
quoted hunk ↗ jump to hunk
Signed-off-by: Matthias Schiffer <redacted>
---
 drivers/net/wireless/ath/ath9k/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/Makefile b/drivers/net/wireless/ath/ath9k/Makefile
index 36a40ffdce15..90e4a341076c 100644
--- a/drivers/net/wireless/ath/ath9k/Makefile
+++ b/drivers/net/wireless/ath/ath9k/Makefile
@@ -59,7 +59,7 @@ obj-$(CONFIG_ATH9K_HW) += ath9k_hw.o
 obj-$(CONFIG_ATH9K_COMMON) += ath9k_common.o
 ath9k_common-y:=	common.o \
 			common-init.o \
-			common-beacon.o \
+			common-beacon.o
 
It's not necessarily stray, there is nothing on the next line so it's
OK, and if you add \ at the end of all lines, you don't have to touch
the last line every time you add/remove something.  Sort of like
putting a , after last enum value.

Just my $.02, not that I mind either way :)
 ath9k_common-$(CONFIG_ATH9K_COMMON_DEBUG) += common-debug.o \
 					     common-spectral.o
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help