Hi Felix,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on v4.14 next-20171122]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Felix-Fietkau/dt-bindings-net-add-mt76-wireless-device-binding/20171123-125723
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All errors (new ones prefixed by >>):

   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function 'mt76x2_mac_process_rate':
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: 'RX_FLAG_SHORTPRE' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: 'RX_FLAG_HT_GF' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: 'RX_FLAG_HT' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: 'RX_FLAG_VHT' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: 'struct ieee80211_rx_status' has no member named 'vht_nss'
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: 'RX_FLAG_LDPC' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: 'RX_FLAG_SHORT_GI' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: 'RX_FLAG_STBC_SHIFT' undeclared (first use in this function)
   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: 'RX_FLAG_40MHZ' undeclared (first use in this function)

quoted

drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: 'struct ieee80211_rx_status' has no member named 'vht_flag'

   drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: 'RX_VHT_FLAG_80MHZ' undeclared (first use in this function)

vim +90 drivers/net/wireless/mediatek/mt76/mt76x2_mac.c

    30	
    31	static void
    32	mt76x2_mac_process_rate(struct ieee80211_rx_status *status, u16 rate)
    33	{
    34		u8 idx = FIELD_GET(MT_RXWI_RATE_INDEX, rate);
    35	
    36		switch (FIELD_GET(MT_RXWI_RATE_PHY, rate)) {
    37		case MT_PHY_TYPE_OFDM:
    38			if (idx >= 8)
    39				idx = 0;
    40	
    41			if (status->band == NL80211_BAND_2GHZ)
    42				idx += 4;
    43	
    44			status->rate_idx = idx;
    45			return;
    46		case MT_PHY_TYPE_CCK:
    47			if (idx >= 8) {
    48				idx -= 8;
  > 49				status->flag |= RX_FLAG_SHORTPRE;
    50			}
    51	
    52			if (idx >= 4)
    53				idx = 0;
    54	
    55			status->rate_idx = idx;
    56			return;
    57		case MT_PHY_TYPE_HT_GF:
    58			status->flag |= RX_FLAG_HT_GF;
    59			/* fall through */
    60		case MT_PHY_TYPE_HT:
    61			status->flag |= RX_FLAG_HT;
    62			status->rate_idx = idx;
    63			break;
    64		case MT_PHY_TYPE_VHT:
    65			status->flag |= RX_FLAG_VHT;
    66			status->rate_idx = FIELD_GET(MT_RATE_INDEX_VHT_IDX, idx);
    67			status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
    68			break;
    69		default:
    70			WARN_ON(1);
    71			return;
    72		}
    73	
    74		if (rate & MT_RXWI_RATE_LDPC)
    75			status->flag |= RX_FLAG_LDPC;
    76	
    77		if (rate & MT_RXWI_RATE_SGI)
    78			status->flag |= RX_FLAG_SHORT_GI;
    79	
    80		if (rate & MT_RXWI_RATE_STBC)
    81			status->flag |= 1 << RX_FLAG_STBC_SHIFT;
    82	
    83		switch (FIELD_GET(MT_RXWI_RATE_BW, rate)) {
    84		case MT_PHY_BW_20:
    85			break;
    86		case MT_PHY_BW_40:
    87			status->flag |= RX_FLAG_40MHZ;
    88			break;
    89		case MT_PHY_BW_80:
  > 90			status->vht_flag |= RX_VHT_FLAG_80MHZ;
    91			break;
    92		default:
    93			break;
    94		}
    95	}
    96	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation